[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables |
Date: |
Thu, 25 Mar 2021 19:00:32 +0200 |
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Spencer Baugh <sbaugh@catern.com>, emacs-devel@gnu.org
> Date: Thu, 25 Mar 2021 12:48:53 -0400
>
> > I'd prefer to pick up where we left off back then. The main issue
> > left unresolved in the past discussion was the potential slowdown of
> > simple accesses to buffer-local vars due to your proposal. Can we
> > please have benchmarks for that, so we could decide whether the
> > tradeoff is worth it? It's quite possible that the performance
> > aspects could affect the code changes, so even uncontroversial
> > cleanups should perhaps wait until we have figured out the more
> > important aspects of these changesets.
>
> I think those changes are good to go and fundamentally unrelated to
> the discussion (except to the extent that they were found while
> investigating that part of the code).
>
> Of course, they may not be the final word, but I'd rather install those
> now so they don't get lost if the rest of the discussion ends up not
> going anywhere and also so the rest of the discussion doesn't need to be
> using patches relative to code that's not in `master`.
Sorry, no. I don't want to make minor cleanups unless they are
related to a useful development. Those cleanups are more trouble than
they are worth (excluding the additions to the test suite, of course).
Nothing of value will be lost if they are lost.
- [PATCH 3/7] Stop checking the constant default for enable_multibyte_characters, (continued)
- [PATCH 3/7] Stop checking the constant default for enable_multibyte_characters, Spencer Baugh, 2021/03/23
- [PATCH 4/7] Take buffer field name in DEFVAR_PER_BUFFER, Spencer Baugh, 2021/03/23
- [PATCH 2/7] Assert not local-variable-p after setq in let_default binding, Spencer Baugh, 2021/03/23
- [PATCH 1/7] Add a test for let-binding unwinding, Spencer Baugh, 2021/03/23
- [PATCH 6/7] Assert that PER_BUFFER_IDX for Lisp variables is not 0, Spencer Baugh, 2021/03/23
- [PATCH 5/7] Combine unnecessarily separate loops in buffer.c, Spencer Baugh, 2021/03/23
- [PATCH 7/7] Remove unnecessary Qunbound check, Spencer Baugh, 2021/03/23
- Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables, Eli Zaretskii, 2021/03/24