[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Improvement proposals for `completing-read'
From: |
Daniel Mendler |
Subject: |
Re: Improvement proposals for `completing-read' |
Date: |
Mon, 12 Apr 2021 13:04:33 +0200 |
On 4/12/21 12:47 PM, Dmitry Gutov wrote:
What happens if you have an anomalously long running request in one
nested minibuffer, which you exit, so it arrives in the "parent" one
that's still managed by Consult, but shows the results for a different
command/input/etc?
This cannot happen. If you exit the minibuffer, the running request will
be terminated. The parent minibuffer, maybe also running a Consult
command (or something else) is isolated from the child minibuffer and no
disruption should happen.
I just tested running nested `consult-ripgrep` and that should work, but
for some reason there is a problem
(https://github.com/minad/consult/issues/272). I have to check if this
can be fixed. So what I described to you is how everything should work
in theory, since the state is captured in the closures.
The `consult--async-sink` contains this code which performs the refreshing:
;; Refresh the UI when the current minibuffer window belongs
;; to the current asynchronous completion session.
(when-let (win (active-minibuffer-window))
(when (eq (window-buffer win) buffer)
(with-selected-window win
(run-hooks 'consult--completion-refresh-hook)))))
Daniel
- Re: Improvement proposals for `completing-read', (continued)
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/08
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/08
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/08
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/09
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/10
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/10
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/11
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/11
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/11
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/12
- Re: Improvement proposals for `completing-read',
Daniel Mendler <=
- Re: Improvement proposals for `completing-read', Dmitry Gutov, 2021/04/13
- Re: Improvement proposals for `completing-read', Daniel Mendler, 2021/04/14
RE: [External] : Improvement proposals for `completing-read', Drew Adams, 2021/04/07
- Re: [External] : Improvement proposals for `completing-read', Daniel Mendler, 2021/04/08
- RE: [External] : Improvement proposals for `completing-read', Drew Adams, 2021/04/08
- Re: [External] : Improvement proposals for `completing-read', Jean Louis, 2021/04/09
- Re: [External] : Improvement proposals for `completing-read', Daniel Mendler, 2021/04/09
- RE: [External] : Improvement proposals for `completing-read', Drew Adams, 2021/04/09
- Re: [External] : Improvement proposals for `completing-read', Daniel Mendler, 2021/04/09