[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re:Re: [patch] * lisp/international/mule-cmds.el (deactivate-input-metho
|
From: |
tumashu |
|
Subject: |
Re:Re: [patch] * lisp/international/mule-cmds.el (deactivate-input-method): Tiny improve. |
|
Date: |
Wed, 28 Apr 2021 20:33:23 +0800 (CST) |
At 2021-04-28 19:54:00, "Eli Zaretskii" <eliz@gnu.org> wrote:
>> Date: Wed, 28 Apr 2021 15:24:40 +0800 (CST)
>> From: tumashu <tumashu@163.com>
>>
>> --- a/lisp/international/mule-cmds.el
>> +++ b/lisp/international/mule-cmds.el
>> @@ -1500,7 +1500,8 @@ deactivate-input-method
>> (progn
>> (setq input-method-function nil
>> current-input-method-title nil)
>> - (funcall deactivate-current-input-method-function))
>> + (when (functionp deactivate-current-input-method-function)
>> + (funcall deactivate-current-input-method-function)))
>
>Thanks, but could you please explain why this is needed? IOW, in
>which use case did you see this function called when
>deactivate-current-input-method-function wasn't a function?
Yes, I have faced some bugs of pyim in evil environment, sometimes, this
variable maybe is nil.
I can not find why.
https://github.com/tumashu/pyim/issues/361
https://github.com/tumashu/pyim/issues/275
https://github.com/tumashu/pyim/issues/367