Re: eval-when-compile help?

[Stefan Monnier]

> +(when (version< emacs-version "28")
> +  (eval-and-compile
> +    (require 'eieio)
> +
> +    (defclass xref-location () ()
> +      :documentation "(Obsolete) location represents a position in a file or 
> buffer.")))
[...]
> Am I overdoing it with 'eval-and-compile'?

I suspect that "from the outside" you don't need the `eval-and-compile`
at all here.  But if you remove it, there's a good chance that
compilation of `defclass` will fail (because the `require` won't be
executed at compile-time).
This said, I'd recommend you hoist the `eval-and-compile` outside of the
`when` so that `eieio` is not loaded in Emacs≥28.


        Stefan