emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Splitting image-dired.el into smaller files


From: Eli Zaretskii
Subject: Re: Splitting image-dired.el into smaller files
Date: Thu, 09 Dec 2021 09:28:11 +0200

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 09 Dec 2021 02:05:02 +0100
> Cc: Mathias Dahl <mathias.dahl@gmail.com>, emacs-devel@gnu.org
> 
> Stefan Kangas <stefan@marxist.se> writes:
> 
> > My current best idea for improving its organization is to split it up in
> > several files along these lines:
> >
> >     image/image-dired-bookmarks.el       ;; bookmark.el support
> >     image/image-dired-compat.el          ;; compatibility layer
> >     image/image-dired-gallery.el         ;; HTML gallery generation
> >     image/image-dired-tags.el            ;; home-cooked image tags
> >     image/image-dired-thumbs.el          ;; thumbnail generation
> >     image/image-dired.el
> >
> > The big drawback here is that we will lose the git history.  However, we
> > lost most of that already in 2007 when the file was renamed.  From my
> > work and what I've seen so far, I don't think I will miss any history
> > that won't be massively outweighed by the benefits of better code
> > organization.
> 
> I think sounds like a good reorganisation, and image-dired could use
> some of that.  (And like Stefan M said, the bookmark stuff seems small
> enough to just keep in image-dired.el.)

If you are going to split the file into several ones, please consider
putting them in their own directory.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]