emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot


From: João Távora
Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot
Date: Tue, 13 Dec 2022 20:18:56 +0000

On Tue, Dec 13, 2022, 19:10 Michael Albinus <michael.albinus@gmx.de> wrote:
João Távora <joaotavora@gmail.com> writes:

Hi João,

>> Do you really need this?
>
> Flymake tells me there are 4 compilation warnings if I don't:
>
>  1243   9 warning  e-f-b-c  Unused lexical variable
> `tramp-remote-path'
>  1243  56 warning  e-f-b-c  reference to free variable
> ‘tramp-remote-path’
>  1244   9 warning  e-f-b-c  Unused lexical variable
> `tramp-histfile-override'
>  1245   9 warning  e-f-b-c  Unused lexical variable `tramp-methods'
>
> Here, the flymake backend 'e-f-b-c' (elisp-flymake-byte-compile)
> compiles with Emacs -Q
> and no specially relevant load path in these cases.

I've fixed this in eglot-tests.el. I've also adapted the two tests wrt
Tramp. Pushed to the emacs-29 branch.

Thanks. I'll have a look later.


FTR, I'm suprised about the names of the test cases. Would it be
possible to give them a unique prefix, like `eglot-test-'?

Yes, do that please. I think this makes sense, although the test symbols aren't exactly bound to functions and it is a nuisance to always type this long boring prefix. If only there was some namespacing mechanism in Emacs that could alleviate that.. oh wait ;-)

João

reply via email to

[Prev in Thread] Current Thread [Next in Thread]