emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tree-sitter introduction documentation


From: Stefan Monnier
Subject: Re: Tree-sitter introduction documentation
Date: Fri, 30 Dec 2022 19:25:22 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

>> Why "--depth 1"?  This should be a defcustom, and the default should
>> be to clone the full repository, IMO.  Also, what about updating the
>> library when it is already installed, and the Git repository already
>> exists for it?  Or are we going to clone anew each time and them
>> remove the repository? that could make its cloning be slow in some
>> cases.
>
> Since the purpose of this command is to install the grammar, why would we
> want a full clone?

Maybe it doesn't matter very much but:
- I suspect most of those grammars have a fairly limited history, so I'd
  expect the savings from `--depth 1` to be rather small.
- And ... [...checking the previous point's theory...]

Wow, that's really weird: they do have a fairly short history (like ~200
commits) but the full clone is *much* larger than the `--depth 1` clone.
I guess it's because they store the generated `.c` file in there and the
small changes in the source cause much larger changes in the
generated file.

> I wanted to keep it simple, synchronous, and quiet, and didn’t thought
> much about it.

I think we should default to asynchonous operations as much as possible.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]