emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/android a496509ced 1/2: Update Android port


From: Stefan Monnier
Subject: Re: feature/android a496509ced 1/2: Update Android port
Date: Wed, 16 Aug 2023 08:35:48 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Po Lu [2023-08-16 20:21:33] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Could you explain why for touchscreen events you made `event-end` and
>> `event-start` return "posn-at-point" (which seems positively useless),
>> forcing you in turn to add ad-hoc handling in `widget-event-point` and
>> to introduce a new `widget-event-start`?
>
> Actually, the cdadr of a touchscreen-begin or touchscreen-end event is
> its mouse position list.

Does that mean that `widget-event-start` doesn't always return a `posn`?
If so, could you add some comments explaining what's going on and why
it's done this way?

>> I understand that touchscreen events may have multiple posns, but it
>> seems that making `event-end` and `event-start` do what
>> `widget-event-point` and `widget-event-start` do would be better than
>> what we have now, no?
> I recall moving the code for processing touch screen events from
> widget.el to subr.el.

AFAICT the code for `event-start/end` in `master` has not been changed
since the above commit.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]