[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [babel][PATCHES] exporting inline source code
From: |
Aaron Ecay |
Subject: |
Re: [O] [babel][PATCHES] exporting inline source code |
Date: |
Sun, 22 Jun 2014 00:02:33 -0400 |
User-agent: |
Notmuch/0.17+160~g03680d1 (http://notmuchmail.org) Emacs/24.4.50.1 (x86_64-unknown-linux-gnu) |
Hi Nicolas,
These both seem like good patches to me. Did you run the test suite to
make sure that no tests are broken by them? It would also be good if
you added some tests for this functionality – the example included at
the bottom of your email is a good starting point. The other babel
export tests live in the file testing/lisp/test-ob-exp.el, so that’s the
spot to look for examples.
Have you heard back from the FSF about your copyright assignment?
Thanks for the patches,
--
Aaron Ecay