Re: [O] [PATCH] small fix for org-log-beginning

[Eric Abrahamsen]

Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> Eric Abrahamsen <address@hidden> writes:
>
>> I'm still slowly chewing on making more use of log items, and found a
>> small bug in org-log-beginning. It contains a partial re-implementation
>> of something we already have a function for: org-log-into-drawer. It was
>> causing me occasional bugs, but I only just looked into it.
>
> Applied. Thank you.
>
>
> Regards,

Ack, wait! I think that was a bad patch. If org-log-into-drawer is
simply set to t, the t falls through into the drawer regexp and causes
and error. I'm sorry -- I was sure I'd tested all the variants.

The question is, should `org-log-into-drawer' always return the string
name of the drawer or nil, or should `org-log-beginning' check if the
return value isn't a string, and substitute the "LOGBOOK" default? I
guess I'm leaning towards the first...

Eric