|
From: | Kyle Meyer |
Subject: | Re: [O] [PATCH] org-attach.el: Fetch attachments from git annex |
Date: | Tue, 05 Jan 2016 01:21:41 -0500 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Thanks for the patch. Erik Hetzner <address@hidden> writes: > +(defun org-attach-use-annex () > + "Return true if we should use git annex for attachments." s/true/non-nil/ > + (let* ((dir (expand-file-name org-attach-directory)) > + (git-dir (vc-git-root dir))) I'd prefer (let ((git-dir (vc-git-root (expand-file-name org-attach-directory)))) ...) [...] > + (if (and (file-symlink-p path) s/if/when/ > + (org-attach-use-annex) > + (not (file-exists-p (file-symlink-p path)))) > + (call-process "git" nil nil nil "annex" "get" path)) - Should this display a message before calling "git annex get" to let the user know what's happening in case fetching the file takes some time? - Should there be a setting the controls whether attachments are automatically fetched? -- Kyle
[Prev in Thread] | Current Thread | [Next in Thread] |