Re: [O] [PATCH] add :session support for ob-js.el

[Nicolas Goaziou]

Hello,

stardiviner <address@hidden> writes:

> updated my code. I followed your suggestions. But modify code one by
> one messed code up. So I merge all related commits into one commit.
> Sorry for this.

Some comments follow.
> +            (result (if (not (string= (cdr (assq :session params)) "none"))

You can integrate the test above in the `cond':

(cond
 ((string= "none" (cdr (assq :session params))) nil)
 ((string= "*JS REPL*" session) ...)
 ...)
> +           (sit-for .5) (goto-char (point-max))

(sit-for .5)
(goto-char (point-max))

> +           (mapc (lambda (var)
> +                         (insert var) (comint-send-input nil t)
> +                         (org-babel-comint-wait-for-output session)
> +                         (sit-for .1) (goto-char (point-max))) var-lines)))
>      session))

  (dolist (var ...)
   ...)

Also, what's your status wrt FSF papers? This cannot fit as
a TINYCHANGE.

Regard,

-- 
Nicolas Goaziou