Re: [O] [PATCH] migrate ob-clojure initiate session code from ob-clojure-literate.el into ob-clojure.el

[stardiviner]

Nicolas Goaziou <address@hidden> writes:

> Hello,
>
> stardiviner <address@hidden> writes:
>
>> Nicolas Goaziou <address@hidden> writes:
>>
>> Hi, sorry for late response, because I'm a little lazy on give effort on
>> review my patch and improve it again. But now I finished it. Actually I
>> corrected my patch as soon as you replied email with mentioned. Today I
>> pick up this task again, and add a new improve which support CIDER new
>> API which using sesman to manage REPL sessions.
>
> OK. So does it qualify as a bug fix, i.e., should that go into master
> branch, or is it a new feature, for next branch?
>
> BTW, there are some compilation warning:
>
> --8<---------------cut here---------------start------------->8---
> Compiling /home/ngz/dev/org-mode/lisp/ob-clojure.el...
>
> In toplevel form:
> ob-clojure.el:215:1:Warning: Unused lexical variable ‘sesman-system’
>
> In org-babel-clojure-initiate-session:
> ob-clojure.el:225:47:Warning: reference to free variable ‘cider-version’
>
> In end of data:
> ob-clojure.el:278:1:Warning: the function ‘cider-repls’ is not known to be
>     defined.
> --8<---------------cut here---------------end--------------->8---
>
> Could you fix them?
>
> Thank you.
>
> Regards,

Hi, Nicolas. I fixed those warning. I think this should be a feature. not a 
patch.

And run `make test`. Here is the result:

```
...
executing Vala source code block
Code block evaluation complete.
   passed  138/814  ob-vala/static-output
   failed  139/814  org-missing-dependency/test-ob-R
   failed  140/814  org-missing-dependency/test-ob-clojure
   failed  141/814  org-missing-dependency/test-ob-lua
   failed  142/814  org-missing-dependency/test-ob-maxima
   failed  143/814  org-missing-dependency/test-ob-plantuml
   failed  144/814  org-missing-dependency/test-ob-ruby
   failed  145/814  org-missing-dependency/test-ob-scheme
   failed  146/814  org-missing-dependency/test-org-attach-annex
   failed  147/814  org-missing-dependency/test-org-protocol
   passed  148/814  test-ob-exp/org-babel-exp-src-blocks/w-no-file
   passed  149/814  test-ob-exp/org-babel-exp-src-blocks/w-no-headers
   passed  150/814  test-ob-exp/org-babel-exp-src-blocks/w-no-headers2
executing Emacs-Lisp code block...
.....
.....
6 unexpected results:
   FAILED  ob-D/inhomogeneous_table
   FAILED  ob-D/list-list-var
   FAILED  ob-D/list-var
   FAILED  ob-D/vector-var
   FAILED  test-org-clock/clocktable/lang
   FAILED  test-org-colview/columns-width
```
Also I added an entry in ORG-NEWS mentioned about this new feature.

0001-ob-clojure.el-Support-org-babel-initiate-session-to-.patch
Description: Text Data

0002-ob-clojure.el-Support-new-CIDER-using-sesman-to-mana.patch
Description: Text Data

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.
       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3