Bug: org-ellipsis does not work as a local variable [9.3.1 (release_9.3.1-95-gf93020 @ /home/mark/git-repos/org-mode/lisp/)]

[Mark E. Shoulson]

The "org-ellipsis" variable is specifically marked as (potentially) a
safe local variable, so obviously someone intended for it possibly to be
used that, and believed that it might be useful to someone as a local
variable.

However, there is no setup that I can find which makes this work.
Placing

:  #  Local Variables:
:  #  org-ellipsis: "XXX"
:  #  End:

at the end of the file, or setting it in the top line, makes no change
in the ellipsis, even if you do M-x org-mode again or reload the file
(with find-alternate-file).  Indeed, M-x org-mode clears the local value
assignment altogether.  Setting it by hand with setq-local doesn't work
(it is cleared when you do M-x org-mode again anyway, as mentioned.)

So, is org-ellipsis really not meant ever to be a local variable?  If
so, that likely should be documented, and certainly the :safe annotation
on it should be removed, as it strongly implies that using it as a local
variable is acceptable and useful.

I ran this with emacs -Q, using using the code from the git repository,
commit f93020d5e6d7594c335cc129ad02c21ac26ed58a (as you can see by the
local filepath below.)  I hope I have explained the bug clearly enough.

Thanks

~mark

Emacs  : GNU Emacs 26.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.13)
 of 2019-12-10
Package: Org mode version 9.3.1 (release_9.3.1-95-gf93020 @ /home/mark/git-repos/org-mode/lisp/)

current state:
==============
(setq
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
             org-src-mode-configure-edit-buffer)
 org-link-shell-confirm-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-reveal-start-hook '(org-decrypt-entry)
 org-mode-hook '((closure
          (org--rds reftex-docstruct-symbol
           org-element-greater-elements org-clock-history
           org-agenda-current-date org-with-time org-defdecode org-def
           org-read-date-inactive org-ans2 org-ans1
           org-columns-current-fmt-compiled org-clock-current-task
           org-clock-effort org-agenda-skip-function
           org-agenda-skip-comment-trees org-agenda-archives-mode
           org-end-time-was-given org-time-was-given
           org-log-note-extra org-log-note-purpose
           org-log-post-message org-last-inserted-timestamp
           org-last-changed-timestamp
           org-entry-property-inherited-from org-blocked-by-checkboxes
           org-state org-agenda-headline-snapshot-before-repeat
           org-capture-last-stored-marker org-agenda-start-on-weekday
           org-agenda-buffer-tmp-name org-priority-regexp
           org-mode-syntax-table buffer-face-mode-face org-tbl-menu
           org-org-menu org-struct-menu org-entities org-last-state
           org-id-track-globally org-clock-start-time texmathp-why
           remember-data-file
           org-agenda-tags-todo-honor-ignore-options
           iswitchb-temp-buflist calc-embedded-open-mode
           calc-embedded-open-formula calc-embedded-close-formula
           align-mode-rules-list org-emphasis-alist
           org-emphasis-regexp-components
           org-export-registered-backends org-modules
           org-babel-load-languages org-indent-indentation-per-level
           org-element-paragraph-separate ffap-url-regexp
           org-inlinetask-min-level t)
          nil
          (add-hook (quote change-major-mode-hook)
           (quote org-show-all) (quote append) (quote local))
          )
         (closure
          (org-src-window-setup *this*
           org-babel-confirm-evaluate-answer-no
           org-src-preserve-indentation org-src-lang-modes
           org-link-file-path-type org-edit-src-content-indentation
           org-babel-library-of-babel t)
          nil
          (add-hook (quote change-major-mode-hook)
           (quote org-babel-show-result-all) (quote append)
           (quote local))
          )
         org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-bibtex-headline-format-function #[257 "\300
\236A\207" [:title] 3 "\n\n(fn ENTRY)"]
 org-babel-pre-tangle-hook '(save-buffer)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
              org-babel-header-arg-expand)
 org-occur-hook '(org-first-headline-recenter)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-show-empty-lines
          org-optimize-window-after-visibility-change)
 org-speed-command-hook '(org-speed-command-activate
              org-babel-speed-command-activate)
 org-confirm-shell-link-function 'yes-or-no-p
 org-link-parameters '(("attachment" :follow org-attach-open-link :complete
            org-attach-complete-link)
               ("id" :follow org-id-open)
               ("eww" :follow eww :store org-eww-store-link)
               ("rmail" :follow org-rmail-open :store
            org-rmail-store-link)
               ("mhe" :follow org-mhe-open :store org-mhe-store-link)
               ("irc" :follow org-irc-visit :store org-irc-store-link
            :export org-irc-export)
               ("info" :follow org-info-open :export org-info-export
            :store org-info-store-link)
               ("gnus" :follow org-gnus-open :store
            org-gnus-store-link)
               ("docview" :follow org-docview-open :export
            org-docview-export :store org-docview-store-link)
               ("bbdb" :follow org-bbdb-open :export org-bbdb-export
            :complete org-bbdb-complete-link :store
            org-bbdb-store-link)
               ("w3m" :store org-w3m-store-link)
               ("bibtex" :follow org-bibtex-open :store
            org-bibtex-store-link)
               ("file+sys") ("file+emacs")
               ("shell" :follow org-link--open-shell)
               ("news" :follow
            (closure
             ((scheme . "news") (--dolist-tail--) org-ts-regexp
              org-time-stamp-formats org-outline-regexp-bol
              org-inhibit-startup org-id-link-to-org-use-id
              org-highlight-links org-comment-string
              org-agenda-buffer-name
              clean-buffer-list-kill-buffer-names t)
             (url) (browse-url (concat scheme ":" url)))
            )
               ("mailto" :follow
            (closure
             ((scheme . "mailto") (--dolist-tail--) org-ts-regexp
              org-time-stamp-formats org-outline-regexp-bol
              org-inhibit-startup org-id-link-to-org-use-id
              org-highlight-links org-comment-string
              org-agenda-buffer-name
              clean-buffer-list-kill-buffer-names t)
             (url) (browse-url (concat scheme ":" url)))
            )
               ("https" :follow
            (closure
             ((scheme . "https") (--dolist-tail--) org-ts-regexp
              org-time-stamp-formats org-outline-regexp-bol
              org-inhibit-startup org-id-link-to-org-use-id
              org-highlight-links org-comment-string
              org-agenda-buffer-name
              clean-buffer-list-kill-buffer-names t)
             (url) (browse-url (concat scheme ":" url)))
            )
               ("http" :follow
            (closure
             ((scheme . "http") (--dolist-tail--) org-ts-regexp
              org-time-stamp-formats org-outline-regexp-bol
              org-inhibit-startup org-id-link-to-org-use-id
              org-highlight-links org-comment-string
              org-agenda-buffer-name
              clean-buffer-list-kill-buffer-names t)
             (url) (browse-url (concat scheme ":" url)))
            )
               ("ftp" :follow
            (closure
             ((scheme . "ftp") (--dolist-tail--) org-ts-regexp
              org-time-stamp-formats org-outline-regexp-bol
              org-inhibit-startup org-id-link-to-org-use-id
              org-highlight-links org-comment-string
              org-agenda-buffer-name
              clean-buffer-list-kill-buffer-names t)
             (url) (browse-url (concat scheme ":" url)))
            )
               ("help" :follow org-link--open-help)
               ("file" :complete org-link-complete-file)
               ("elisp" :follow org-link--open-elisp)
               ("doi" :follow org-link--open-doi))
 org-link-elisp-confirm-function 'yes-or-no-p
 )