[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug or not a bug? dot expansion in ob-shell
From: |
Nick Dokos |
Subject: |
Re: Bug or not a bug? dot expansion in ob-shell |
Date: |
Thu, 20 Feb 2020 15:37:42 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Bastien,
Bastien <address@hidden> writes:
> Hi Diego,
>
> Diego Zamboni <address@hidden> writes:
>
>> I'm late to the discussion so I apologize in advance, but this fix
>> seems counterintuitive to me. In my mind, for any shell code:
>>
>> - Return value: exit code of the last command
>> - Output: whatever the commands print
>
> Yes, that's what is *now* possible if you set
> ob-shell-return-value-is-exit-status to t.
>
> Unless I miss something, it was not possible before today.
>
> #+begin_src shell
> echo Hello!
> #+end_src
>
> would simply return "Hello!" as a return.
>
> No exit code was *never* output.
>
>> So to me, it's intuitive that =:exports value= would return the exit
>> code of the last command, and =:exports output= would produce the
>> output of the commands. I don't understand why a new option is
>> needed.
>
> ... because it was not the case before. Or maybe *I* miss something.
>
> Can you show me something that was working before and that is not
> anymore?
>
> Thanks,
I welcome the fix but not the option: the option situation in Org mode
was pretty horrible, then ca 2010, you did a survey and some options
were eliminated (not sure about the year or whether it *was* you who
did the survey, but I'm pretty sure there was one): that was the right
direction to go, but it wasn't enough. Org mode needs to be put into
an option diet, so adding another one here (and a rather gratuitous
one in my view) is not the way to go.
`:results value' should *always* produce the value of the last expression,
which for shell programs is the exit status of the last command.
`:results output' should *always* produce all of the output of the program.
An argument can be made that `:results value' is the default, but it
is the less useful option for shell programs. So maybe for shell
blocks, make the default to be `:results output' instead: people get
what they always got before the fix without lifting a finger, the exit status
is now available with `:results value', and the option can go away
quietly and quickly, before it becomes another contributor to the Org
mode technical debt.
--
Nick
"There are only two hard problems in computer science: cache
invalidation, naming things, and off-by-one errors." -Martin Fowler
- Re: Bug or not a bug? dot expansion in ob-shell, (continued)
- Re: Bug or not a bug? dot expansion in ob-shell, Fraga, Eric, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Fraga, Eric, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Diego Zamboni, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Samuel Wales, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/19
- Re: Bug or not a bug? dot expansion in ob-shell,
Nick Dokos <=
- Re: Bug or not a bug? dot expansion in ob-shell, Tim Cross, 2020/02/20
- Re: Bug or not a bug? dot expansion in ob-shell, Derek Feichtinger, 2020/02/21
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/21
- Re: Bug or not a bug? dot expansion in ob-shell, Nick Dokos, 2020/02/21
- Re: Bug or not a bug? dot expansion in ob-shell, Jack Kamm, 2020/02/22
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/22
- Re: Bug or not a bug? dot expansion in ob-shell, Stefan Nobis, 2020/02/23
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/23
- Re: Bug or not a bug? dot expansion in ob-shell, Jack Kamm, 2020/02/23
- Re: Bug or not a bug? dot expansion in ob-shell, Bastien, 2020/02/23