emacs-orgmode
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ox.html causes w3c xhtml validation

From: Arne Babenhauserheide
Subject: Re: ox.html causes w3c xhtml validation
Date: Sun, 15 Mar 2020 23:40:49 +0100
User-agent: mu4e 1.2.0; emacs 26.3 
Dear Kyle, Dear Colin,

Colin Baxter <address@hidden> writes:
>     >> ./lisp/ox-html.el:235:// @license
>     >> 
> magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt
>     >> GPL-v3-or-Later
>     > [...]
>     >> I think the culprit is commit
>     >> 68fa5e589f00c8d5b4f7f0dc70be6ebe59238bb8, 11 Feb.

>     > From what I gather from briefly searching around (mostly based on
>     > this information [0]), I don't think there's an easy fix for
>     > inline javascript.
>
> In my opinion, if it can't be fixed then the changes should be
> removed. Surely, we cannot have an org-mode that knowingly
> exports/publishes something that causes a validation error!
>
>     > I wonder if Arne [+cc], who suggested the change [1], knows of a
>     > solution.

Firstoff: I can reproduce this by using an xhtml header:

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" 
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd";>
    <html xmlns="http://www.w3.org/1999/xhtml";>

And second: I just verified that LibreJS still recognizes the license
when we escape the & as &amp;

I would suggest the following:

diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 9a1dd44b5..5c2b766e9 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -232,7 +232,7 @@ property on the headline itself.")
 
 (defconst org-html-scripts
   "<script type=\"text/javascript\">
-// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt 
GPL-v3-or-Later
+// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&amp;dn=gpl-3.0.txt 
GPL-v3-or-Later
 <!--/*--><![CDATA[/*><!--*/
      function CodeHighlightOn(elem, id)
      {
@@ -510,12 +510,12 @@ means to use the maximum value consistent with other 
options."
 
 (defcustom org-html-infojs-template
   "<script type=\"text/javascript\" src=\"%SCRIPT_PATH\">
-// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt 
GPL-v3-or-Later
+// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&amp;dn=gpl-3.0.txt 
GPL-v3-or-Later
 // @license-end
 </script>
 
 <script type=\"text/javascript\">
-// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt 
GPL-v3-or-Later
+// @license 
magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&amp;dn=gpl-3.0.txt 
GPL-v3-or-Later
 <!--/*--><![CDATA[/*><!--*/
 %MANAGER_OPTIONS
 org_html_manager.setup();  // activate after the parameters are set

Thank you for CC'ing me!

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein
ohne es zu merken
reply via email to
[Prev in Thread] Current Thread [Next in Thread]