[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-agenda.el: Complete multiple todo keywords

From: Kyle Meyer
Subject: Re: [PATCH] org-agenda.el: Complete multiple todo keywords
Date: Thu, 30 Apr 2020 04:04:39 +0000

Thanks for the patch.  Looks like a nice improvement to me.

akater <address@hidden> writes:

> * lisp/org-agenda.el (org-todo-list): Use completing-read-multiple
> instead of completing-read when selecting todo keywords to filter by
> in Agenda.

This and the rest of the lines were unwrapped.  Could you wrap them ~70
characters?  (The Org repo's .dir-locals.el sets fill-column to 70.)

> * lisp/org-agenda.el (org-todo-list): Fix a typo in the prompt.

Thanks for spotting that typo.  I think it'd be more common to append
this description to the entry above rather than adding another
org-todo-list entry.

> There is minor UX cost to Helm users: while candidates list used to
> appear immediately to Helm users, now Helm users have to hit TAB to
> see the list.

Just the opinion of one Helm user, but needing to hit tab for crm-based
completion has never bothered me too much.  But if it did, Helm allows
specifying that certain commands should go through the built-in

Out of curiosity I tried with the latest ivy (9e0803c), and I also
needed to hit tab before seeing anything.

> This inconsistency is not present in vanilla Emacs
> completion.

I'm confused by this.  When I try with no customization (Emacs 26.3), I
need to hit tab to see any of the candidates.

> The issue had been discussed with experienced Helm developer who
> insisted that current Helm behaviour should not change.

I think this bit can be pruned from the commit message.

> We opted to use custom separator that is more natural in context.

Looks like you stuck with "|" as the separator, which seems like a good
idea to me.

> However, it is unfortunate that string patterns are strings themselves
> and are thus indistinguishable from strings; it would be better if crm
> exposed separator (the string) on its own in its interface.

I'm not quite sure I follow what you're suggesting with the last bit.
Could you rephrase the point in a way that is a bit more connected with
the code change?  This patch sticks with the same separator, so aside
from being able to complete multiple things, there's no change in
behavior/added restriction here, right?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]