[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Enhance org-html--build-meta-info
From: |
TEC |
Subject: |
Re: [PATCH] Enhance org-html--build-meta-info |
Date: |
Thu, 21 Jan 2021 13:55:07 +0800 |
User-agent: |
mu4e 1.4.14; emacs 27.1 |
Kyle Meyer <kyle@kyleam.com> writes:
> I've applied this (a8df7670c) with two minor changes (shown in the diff
> at end): s/with with/with/ in a docstring and move an element to its own
> line to avoid the warning from lisp-mode's lisp--match-hidden-arg.
Thanks :)
> This thread has gone on long enough that I'll avoid requesting changes
> for convention/style nits, but some things to keep in mind for future
> patches:
I'll try to keep these in mind in future. Might there be a Worg page or
something listing all of these little things so I don't keep on being
told of them a few at a time as I violate them?
> Also, it'd be good for this to be accompanied by a NEWS entry. I'd
> appreciated if that were sent in a separate thread, though. For some
> reason I haven't debugged, my usual MUA can't load this thread.
Will do 👍.
--
Timothy
- Re: [PATCH] Enhance org-html--build-meta-info, (continued)
- Re: [PATCH] Enhance org-html--build-meta-info, Jens Lechtenboerger, 2021/01/03
- Re: [PATCH] Enhance org-html--build-meta-info, TEC, 2021/01/03
- Re: [PATCH] Enhance org-html--build-meta-info, Jens Lechtenboerger, 2021/01/04
- Re: [PATCH] Enhance org-html--build-meta-info, TEC, 2021/01/10
- Re: [PATCH] Enhance org-html--build-meta-info, Jens Lechtenboerger, 2021/01/10
- Re: [PATCH] Enhance org-html--build-meta-info, TEC, 2021/01/10
- Re: [PATCH] Enhance org-html--build-meta-info, TEC, 2021/01/14
- Re: [PATCH] Enhance org-html--build-meta-info, Jens Lechtenboerger, 2021/01/14
- Ready to merge! Re: [PATCH] Enhance org-html--build-meta-info, TEC, 2021/01/14
- Re: [PATCH] Enhance org-html--build-meta-info, Kyle Meyer, 2021/01/20
- Re: [PATCH] Enhance org-html--build-meta-info,
TEC <=