|
From: | Ryan Scott |
Subject: | Re: [PATCH] Re: New source block results option for attaching file to node |
Date: | Tue, 14 Jun 2022 11:23:59 -0700 |
Ryan Scott <ryan@vicarious-living.com> writes:
> I put together a clean setup in docker for running the tests and believe
> I've gotten to the source of the problem.
> However I've thought that a few times now.
Would you be interested to share it? It might be helpful for other
people trying to develop on Windows.
> This version of the patch has all tests passing.
> The problem was in org-results-to-file and the attach dir detection. It
> both had problems with an introduced assumption that the buffer-file-name
> would be non-nil (causing several tests to fail) as well as being generally
> overzealous in detecting file result paths as attachment links.
Thanks!
Applied onto main via 226119124 with several amendments.
I have added some missing "." at the end of sentences, made sure that
all sentences are separated by doube " " as required by our conventions
and dropped `quoting' from non-symbols.
Best,
Ihor
[Prev in Thread] | Current Thread | [Next in Thread] |