Re: incorrect XIM spot

[Kenichi Handa]

In article <address@hidden>, Kenichi Handa <address@hidden> writes:

> I got a report about the bug of xic_set_preeditarea perhaps
> caused by the recent change for fringe treatment.
> Currently, the input method spot is set to incorrect X
> position.  The suggested fix is attached.  I confirmed that
> it surely fixes the bug.

> Kim, could you plese check this and install it if it is the
> correct way of fixing the bug?  I myself has not yet studied
> the usage of these macros, thus am not sure if there's a
> better way or not.

Although I have not yet got a reply from Kim, I've just
installed this patch because the bug is quite annoying for
an XIM user.

---
Ken'ichi HANDA
address@hidden


> 2003-06-05  KOBAYASHI Yasuhiro  <address@hidden> (tiny change)

>       * xfns.c (xic_set_preeditarea): Add the left fringe width to
>         spot.x.

> *** xfns.c.~1.583.~   Fri May 30 16:07:50 2003
> --- xfns.c    Thu Jun  5 11:08:09 2003
> ***************
> *** 2331,2337 ****
>     XVaNestedList attr;
>     XPoint spot;
  
> !   spot.x = WINDOW_TO_FRAME_PIXEL_X (w, x);
>     spot.y = WINDOW_TO_FRAME_PIXEL_Y (w, y) + FONT_BASE (FRAME_FONT (f));
>     attr = XVaCreateNestedList (0, XNSpotLocation, &spot, NULL);
>     XSetICValues (FRAME_XIC (f), XNPreeditAttributes, attr, NULL);
> --- 2331,2337 ----
>     XVaNestedList attr;
>     XPoint spot;
  
> !   spot.x = WINDOW_TO_FRAME_PIXEL_X (w, x) + WINDOW_LEFT_FRINGE_WIDTH (w);
>     spot.y = WINDOW_TO_FRAME_PIXEL_Y (w, y) + FONT_BASE (FRAME_FONT (f));
>     attr = XVaCreateNestedList (0, XNSpotLocation, &spot, NULL);
>     XSetICValues (FRAME_XIC (f), XNPreeditAttributes, attr, NULL);




> In GNU Emacs 21.3.50.3 (sparc-sun-solaris2.8, X toolkit, Xaw3d scroll bars)
>  of 2003-06-05 on mule
> configured using `configure  'LDFLAGS=-R/usr/local/lib''

> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: ja
>   locale-coding-system: japanese-iso-8bit
>   default-enable-multibyte-characters: t

> Recent input:
> t o SPC s p o t . x . <escape> q C-x C-s C-p C-p C-p 
> C-p C-e M-b M-b M-b M-f M-f M-b C-s C-w C-w C-s C-f 
> C-b <M-delete> m 1 7 n . o r g C-a C-x C-s <help-echo> 
> M-f M-f M-f M-b M-f M-f M-b C-y C-k C-x C-x M-f M-f 
> SPC C-e SPC ( t i M-/ <M-delete> t i <delete> i n y 
> SPC M-/ ) . <delete> M-b M-b C-s C-w C-w C-s C-x C-x 
> C-a C-x C-s <escape> x r e p o r t SPC e m <tab> <
return> 

> Recent messages:
> Wrote /project/mule/emacs-head/src/ChangeLog
> Mark saved where search started
> Saving file /project/mule/emacs-head/src/ChangeLog...
> Wrote /project/mule/emacs-head/src/ChangeLog
> Mark set
> Loading dabbrev...done
> Mark saved where search started
> Saving file /project/mule/emacs-head/src/ChangeLog...
> Wrote /project/mule/emacs-head/src/ChangeLog
> Loading emacsbug...done


> _______________________________________________
> Emacs-pretest-bug mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/emacs-pretest-bug