Re: Holidays in fancy diary

[Jason Rumney]

Ed Reingold <address@hidden> writes:

> > Ed Reingold <address@hidden> writes:
> > 
> > > Richard--whoever made these changes is an ass who does not know what
> > > he or she is doing. 
> > 
> > Calm down. It looks like the only problem with that change is that it
> > causes the macro to return nil, doesn't it? We can fix that without
> > reintroducing the bug that the changes were designed to fix.
> 
> No!!! The change mucks about with the BC/AD change which is irrelevant and 
> wrong.  It needs to be AS IT WAS.

Perhaps you should add some comments somewhere explaining why the
BC/AD change should be as it was, because it certainly looks like the
previous code did not take into account that there was no year 0, so I
am not surprised someone thought it was a bug and fixed it.