emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug fix for `kbd' in 21.3.50.5


From: Emilio Lopes
Subject: bug fix for `kbd' in 21.3.50.5
Date: Sun, 06 Jun 2004 16:53:51 +0200
User-agent: Emacs Gnus

Hi,

the definition of the macro `kbd' in lisp/subr.el is not correctly
quoted (indeed it's not quoted at all) so that one gets

   (macroexpand '(kbd "C-x C-f"))
   => "^X^F"

instead of the correct

   (macroexpand '(kbd "C-x C-f"))
   => (read-kbd-macro "C-x C-f")

As a consequence constructions like the one bellow result in an error

   (let ((key/command-pair '("C-c u" . goto-line)))
     (global-set-key (kbd (car key/command-pair)) (cdr key/command-pair)))

Here is the fix:

2004-06-06  Emilio C. Lopes  <address@hidden>

        * subr.el (kbd): added quoting in macro definition

*** lisp/subr.el.~1.396.~       Sun Jun  6 15:32:07 2004
--- lisp/subr.el        Sun Jun  6 16:14:20 2004
***************
*** 567,573 ****
    "Convert KEYS to the internal Emacs key representation.
  KEYS should be a string constant in the format used for
  saving keyboard macros (see `insert-kbd-macro')."
!   (read-kbd-macro keys))
  
  (put 'keyboard-translate-table 'char-table-extra-slots 0)
  
--- 567,573 ----
    "Convert KEYS to the internal Emacs key representation.
  KEYS should be a string constant in the format used for
  saving keyboard macros (see `insert-kbd-macro')."
!   `(read-kbd-macro ,keys))
  
  (put 'keyboard-translate-table 'char-table-extra-slots 0)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]