partial-completion-mode and common/uncommon parts.

[Matt Hodges]

In GNU Emacs 21.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.4.3)
 of 2004-07-20 on dugong
configured using `configure '--with-gtk''

In completion-setup-function, no account is taken of
partial-completion-mode, and when this mode is turned on, the
completions-common-part and completions-first-difference face
properties can be added incorrectly.

I have a fix for this that takes account of point in the minibuffer
when completion-setup-function is called; see attached patch.

This doesn't work if the text to be completed starts with a "-", but
the behaviour of partial-completion-mode when this is the case seems
odd anyway. For example if you type "M-x ---buffer" then TAB, the
cursor ends up after the first "-" rather than before it. I can't
understand this as a feature, but the following also seems wrong:
typing "M-x -lock-mode" then TAB leaves point at the end of the
minibuffer contents, but the only completion to be done is before the
first "-". Moving the cursor before the first "-" and pressing TAB
leads to point moving to the end of the minibuffer contents.
(Completion works fine for something like "f-lock-mode", though.)

Thanks,

Matt

simple.el.patch
Description: simple.el patch.