[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: substitute-key-definition problem with menus in Emacs 21

From: Richard Stallman
Subject: Re: substitute-key-definition problem with menus in Emacs 21
Date: Mon, 11 Oct 2004 12:45:07 -0400

    In any case, isn't your definition of substitute-key-definition equivalent 

    (defun substitute-key-definition (olddef newdef keymap &optional oldmap 
      (or prefix (setq prefix ""))
      (let* ((scan (or oldmap keymap))
             (prefix1 (vconcat prefix [nil]))
              (cons scan key-substitution-in-progress)))
        ;; Scan OLDMAP, finding each char or event-symbol that
        ;; has any definition, and act on it with hack-key.

I just fixed the bug.  If this simplification works, go ahead
and install it.

A comment in the code suggests in some cases this might have
bad results with chartables.  Specifically when the chartable
has an entry that applies to an entire character set.  It might
get replaced with a lot of entries for individual characters.
I am not sure if this is really possible, though.

The existing code might also have that problem.  To avoid the problem
might require more work on the chartable case.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]