Re: Undo discard prompt (was: [T. V. Raman] read-only modes should be using buffer-disable-undo?)

[Luc Teirlinck]

Richard Stallman wrote:

   Please install your patch.
   However, undo-ask-before-discard should t for now.

   Please put a note in NEWS as a reminder to change the manual.

What about the following doc changes?  I have kept
`undo-ask-before-discard' t in the code, but all doc changes assume it
is nil, because, if I understand correctly that is what we plan to do
before the release.

===File ~/NEWS-diff=========================================
*** NEWS        29 Jan 2005 13:27:30 -0600      1.1112
--- NEWS        29 Jan 2005 18:47:37 -0600      
***************
*** 175,182 ****
  
  +++
  ** When the undo information of the current command gets really large
! (beyond the value of `undo-outer-limit'), Emacs asks you whether to
! discard it or keep it.
  
  ** line-move-ignore-invisible now defaults to t.
  
--- 175,182 ----
  
  +++
  ** When the undo information of the current command gets really large
! (beyond the value of `undo-outer-limit'), Emacs discards it and warns
! you about it.
  
  ** line-move-ignore-invisible now defaults to t.
  
============================================================

===File ~/basic.texi-diff===================================
*** basic.texi  27 Dec 2004 15:04:17 -0600      1.40
--- basic.texi  29 Jan 2005 19:48:41 -0600      
***************
*** 399,411 ****
  
    Regardless of the values of those variables, the most recent change
  is never discarded unless it gets bigger than @code{undo-outer-limit}
! (normally 300,000).  At that point, Emacs asks whether to discard the
! undo information even for the current command.  (You also have the
! option of quitting.)  So there is normally no danger that garbage
! collection occurring right after an unintentional large change might
! prevent you from undoing it.  But if you didn't expect the command
! to create such large undo data, you can get rid of it and prevent
! Emacs from running out of memory.
  
    The reason the @code{undo} command has two keys, @kbd{C-x u} and
  @kbd{C-_}, set up to run it is that it is worthy of a single-character
--- 399,411 ----
  
    Regardless of the values of those variables, the most recent change
  is never discarded unless it gets bigger than @code{undo-outer-limit}
! (normally 3,000,000).  At that point, Emacs discards the undo data and
! warns you about it.  This is the only situation in which you can not
! undo the last command.  If this happens, you can increase the value of
! @code{undo-outer-limit} to make it even less likely to happen in the
! future.  But if you didn't expect the command to create such large
! undo data, then it is probably a bug and you should report it.
! @xref{Bugs,, Reporting Bugs}.
  
    The reason the @code{undo} command has two keys, @kbd{C-x u} and
  @kbd{C-_}, set up to run it is that it is worthy of a single-character
============================================================

===File ~/text.texi-diff====================================
*** text.texi   29 Jan 2005 13:29:53 -0600      1.88
--- text.texi   29 Jan 2005 20:40:10 -0600      
***************
*** 1309,1316 ****
  them from using up all available memory space, garbage collection trims
  them back to size limits you can set.  (For this purpose, the ``size''
  of an undo list measures the cons cells that make up the list, plus the
! strings of deleted text.)  Two variables control the range of acceptable
! sizes: @code{undo-limit} and @code{undo-strong-limit}.
  
  @defvar undo-limit
  This is the soft limit for the acceptable size of an undo list.  The
--- 1309,1317 ----
  them from using up all available memory space, garbage collection trims
  them back to size limits you can set.  (For this purpose, the ``size''
  of an undo list measures the cons cells that make up the list, plus the
! strings of deleted text.)  Three variables control the range of acceptable
! sizes: @code{undo-limit}, @code{undo-strong-limit} and
! @code{undo-outer-limit}.
  
  @defvar undo-limit
  This is the soft limit for the acceptable size of an undo list.  The
***************
*** 1321,1327 ****
  This is the upper limit for the acceptable size of an undo list.  The
  change group at which this size is exceeded is discarded itself (along
  with all older change groups).  There is one exception: the very latest
! change group is never discarded no matter how big it is.
  @end defvar
  
  @node Filling
--- 1322,1334 ----
  This is the upper limit for the acceptable size of an undo list.  The
  change group at which this size is exceeded is discarded itself (along
  with all older change groups).  There is one exception: the very latest
! change group is only discarded if it exceeds @code{undo-outer-limit}.
! @end defvar
! 
! @defvar undo-outer-limit
! If at garbage collection time the undo info for the current command
! exceeds this limit, Emacs discards the info and prints a warning
! message.  This is a last ditch limit to prevent memory overflow.
  @end defvar
  
  @node Filling
============================================================