Re: ispell.el sometimes doesn't use the right dictionary.

[Lute Kamstra]

Richard Stallman <address@hidden> writes:

> There was a lot of confusion in the ispell code between variables
> used for user-level specifications and internal records.
>
> Does this patch give good results?

When I do a make bootstrap with your patch I get:

  [...]
  
  Loading cus-start (source)...
  Loading international/mule (source)...
  Loading international/mule-conf.el (source)...
  Loading format (source)...
  Loading bindings (source)...
  Loading files (source)...
  Loading cus-face (source)...
  Loading faces (source)...
  Lists of integers (garbage collection statistics) are normal output
  while building Emacs; they do not indicate a problem.
  ((89347 . 24715) (5282 . 46) (562 . 121) 336557 18907 (14 . 1) (18 . 0) (6707 
. 349))
  Loading loaddefs.el (source)...
  Symbol's function definition is void: ispell-valid-dictionary-list
  make[1]: *** [bootstrap-emacs] Error 255
  make[1]: Leaving directory `/soft/careful/emacs/src'
  make: *** [bootstrap-build] Error 2

It seems that the (fboundp 'ispell-valid-dictionary-list) test in this
part of the patch should not have been removed:

> ***************
> *** 902,911 ****
>   
>   ;;;###autoload
>   (if ispell-menu-map-needed
> !     (let ((dicts (if (fboundp 'ispell-valid-dictionary-list)
> !                  (ispell-valid-dictionary-list)
> !                (mapcar (lambda (x) (or (car x) "default"))
> !                        ispell-dictionary-alist)))
>         (dict-map (make-sparse-keymap "Dictionaries")))
>         (setq ispell-menu-map (make-sparse-keymap "Spell"))
>         ;; add the dictionaries to the bottom of the list.
> --- 870,876 ----
>   
>   ;;;###autoload
>   (if ispell-menu-map-needed
> !     (let ((dicts (ispell-valid-dictionary-list))
>         (dict-map (make-sparse-keymap "Dictionaries")))
>         (setq ispell-menu-map (make-sparse-keymap "Spell"))
>         ;; add the dictionaries to the bottom of the list.

I put the test back in and now things seem to work fine: the bug I
reported is fixed.  Thank you.


Lute.