cvs-retrieve-revision passes wrong BUFFER argument to call-process

[Wolfgang Jenkner]

In lisp/pcvs.el, cvs-retrieve-revision passes to call-process a bogus
(I think) BUFFER argument: It does not match the function description
and the effect (from looking at the code in src/callproc.c) seems to
be the same as if (t t) were passed.  I propose the following patch:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cut ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Index: pcvs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs.el,v
retrieving revision 1.74
diff -C2 -r1.74 pcvs.el
*** pcvs.el     1 Dec 2004 22:35:15 -0000       1.74
--- pcvs.el     21 Feb 2005 15:23:07 -0000
***************
*** 1688,1693 ****
          ;; Discard stderr output to work around the CVS+SSH+libc
          ;; problem when stdout and stderr are the same.
!         ;; FIXME: this doesn't seem to make any difference :-(
!         (let ((res (apply 'call-process cvs-program nil '(t . nil) nil
                            "-q" "update" "-p"
                            ;; If `rev' is HEAD, don't pass it at all:
--- 1688,1692 ----
          ;; Discard stderr output to work around the CVS+SSH+libc
          ;; problem when stdout and stderr are the same.
!         (let ((res (apply 'call-process cvs-program nil '(t nil) nil
                            "-q" "update" "-p"
                            ;; If `rev' is HEAD, don't pass it at all:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cut ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

W. Jenkner