[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Default :group in lisp/emacs-lisp/easy-mmode.el.

From: Lute Kamstra
Subject: Re: Default :group in lisp/emacs-lisp/easy-mmode.el.
Date: Sun, 03 Apr 2005 21:41:52 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Luc Teirlinck <address@hidden> writes:

> After Lute's patch the define-minor-mode for `diff-minor-mode' would
> have to be given an explicit :group, or diff-minor-mode-hook would be
> moved from the diff-mode group (where it belongs) to the bogus
> diff-minor group (if I understood Lute's patch correctly).  I am now
> convinced that there must be tons of other examples.

Please note that so far, I've installed just this patch:

2005-03-31  Lute Kamstra  <address@hidden>

        * emacs-lisp/easy-mmode.el (easy-mmode-define-global-mode)
        (define-minor-mode): Call custom-current-group at load-time.

Before this change, define-minor-mode set the default :group for
defcustom forms based on the mode name.  After this change,
define-minor-mode first tries to use custom-current-group for the
default value of :group and falls back to the mode name if
custom-current-group fails.

rms didn't like this new behavior so the second patch I posted (and
did not install yet) merely changes the behavior of define-major-mode
back to the situation before 2005-03-31.  So implying that my (second)
patch has big consequences is not really fair.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]