[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tmm and enabled menus.

From: Nick Roberts
Subject: tmm and enabled menus.
Date: Sat, 14 May 2005 11:22:55 +1200

 > When using tmm-menubar, tmm-get-keymap checks for the menu-enable
 > property, but doesn't check for menus and menu items made inactive
 > through the :enable keyword.  A proposed patch to fix this is
 > attached.

I've noticed this problem. This patch looks good (I've tested it).

 > I also noticed that the documentation for easy-menu-define says that
 > for menus, :include is an alias for :visible; I think this should be
 > :included.  For menu items, :visible is supported but not mentioned,
 > so unless there is a reason for this difference, maybe the
 > documentation describing the menu and menu item keywords should be
 > made equivalent in this respect.

Also the manual only describes :visible and this is more
self-explanatory. This seems a reasonable change to me.

I have committed these changes to speed things up. I don't know (but will
find out, I guess!) if I have exceeded my authority.

Do include the ChangeLog entry, but not as a patch - ChangeLog changes too
quickly to apply it successfully. Actually, as you appear to already have
many entries in the ChangeLog, the sensible thing would seem to be to give
you write access to the repository.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]