emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: loaddefs.el on Windows incomplete


From: Eli Zaretskii
Subject: Re: loaddefs.el on Windows incomplete
Date: Sat, 09 Jul 2005 01:06:20 +0300

> From: Ralf Angeli <address@hidden>
> Date: Fri, 08 Jul 2005 23:06:09 +0200
> 
> Okay, with the following patch (thanks, David, for reminding me of the
> technique) I can build Emacs under Windows using mingw32-make (MinGW
> 4.1.0) with MSYS' (1.0.10) sh.exe either present or not.

Thanks for working on this.

> 2005-07-08  Ralf Angeli  <address@hidden>
> 
>       * makefile.w32-in (autoloads): Do not let autoload file name be
>       mangled by the shell.
> 
> 
> --- makefile.w32-in   4 Jul 2005 23:08:56 -0000       1.44
> +++ makefile.w32-in   8 Jul 2005 20:52:06 -0000
> @@ -149,11 +149,14 @@
>  autoloads: loaddefs.el doit
>       @echo Directories: $(WINS)
>       $(emacs) -l autoload \
> -             --eval $(ARGQUOTE)(setq find-file-hook nil \
> -                     find-file-suppress-same-file-warnings t \
> -                     generated-autoload-file \
> -                       $(DQUOTE)$(lisp)/loaddefs.el$(DQUOTE))$(ARGQUOTE) \
> -             -f batch-update-autoloads $(lisp) $(WINS)
> +               --eval $(ARGQUOTE)(let ((find-file-hook nil) \
> +                       (find-file-suppress-same-file-warnings t) \
> +                       (generated-autoload-file \
> +                         (expand-file-name (pop command-line-args-left)))) \
> +                       (mapcar (function update-directory-autoloads) \
> +                         command-line-args-left) \
> +                       (save-buffers-kill-emacs t))$(ARGQUOTE) \
> +               "$(lisp)/loaddefs.el" $(lisp) $(WINS)

Good God!  Can you please explain why we need such a monstrosity with
MSYS, and why the original version fails (i.e., why is the file name
mangled)?  It's hard to argue about this patch without understanding
that much, and it's harder still to try to figure out whether it might
hamper other build environments.  (FWIW, my environment is identical
to yours except that the shell is not the one from MSYS.  I have no
problems with the original command, although I use the same port of
Make.)

Btw, isn't MinGW 4.1.0 a development snapshot, not a released version?
If so, perhaps it's a bug in that version of MinGW (I have 3.7 on my
box).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]