[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: descibe-mode problem

From: Katsumi Yamaoka
Subject: Re: descibe-mode problem
Date: Wed, 13 Jul 2005 09:47:37 +0900
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>>>>> In [semi-gnus-ja : No.13869] Richard M. Stallman wrote:

>     I'm confused.  That is the same as the case where the 5th arg is
>     omitted.  Does it mean that to specify the 5th arg of
>     `add-minor-mode' is meaningless?

> I am not 100% sure, but the normal convention is that the
> 5th arg should be the same as the 1st arg, and it is clearly
> better to follow that convention.

I agree with you basically.  And now, I think the 5th arg is
useless in Emacs since the function doesn't seem to be used
anywhere.  So, I'll make it nil for Emacs in Gnus v5.11 later.

In XEmacs, I realized the function is incorporated into the menu
which is opened by clicking of the mouse-3 on the minor-mode
indicator in the mode-line.  The code used in Gnus is as follows:

      (add-minor-mode 'gnus-topic-mode " Topic"
                           gnus-topic-mode-map nil (lambda (&rest junk)
                                                     (gnus-topic-mode nil t)))

The interactive spec of the `gnus-topic-mode' function is:

(defun gnus-topic-mode (&optional arg redisplay)
  "Minor mode for topicsifying Gnus group buffers."
  (interactive (list current-prefix-arg t))

The 2nd arg `redisplay' should be t for the interactive use.  I
guess the 5th arg of `add-minor-mode' above is for only XEmacs,
and it wasn't called interactively from the menu in the past
maybe, while I confirmed the most recent XEmacsen call it
interactively.  So, I'll remove the 5th arg unconditionally in
No Gnus v0.4, but remove it for only Emacs in Gnus v5.11 (which
is included in Emacs CVS, but also supports old XEmacsen).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]