emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rxvt vs xterm keybindings


From: Dan Nicolaescu
Subject: Re: rxvt vs xterm keybindings
Date: Tue, 26 Jul 2005 10:20:06 -0700

"Richard M. Stallman" <address@hidden> writes:

  >     I am not very happy with the name of the function use to initialize
  >     the terminals:  TERMNAME-initialize-terminal. I would appreciate
  >     better ideas. (maybe use initialize-terminal-TERMNAME ?)
  > 
  > terminal-init-TERMNAME would be the clearest, I think.
  > 
  > But I have another idea.  Instead of autoloading these functions,
  > check for the file's existence just as now, and load it as now.
  > The only change in startup.el would be to call this generated function name
  > after loading the file.

Sounds good. Here is an implementation of that. 
May I check this in? 


*** startup.el  22 Jul 2005 20:17:09 -0700      1.369
--- startup.el  26 Jul 2005 10:13:20 -0700      
***************
*** 984,990 ****
          (setq term
                (if (setq hyphend (string-match "[-_][^-_]+$" term))
                    (substring term 0 hyphend)
!                 nil)))))
  
    ;; Update the out-of-memory error message based on user's key bindings
    ;; for save-some-buffers.
--- 984,994 ----
          (setq term
                (if (setq hyphend (string-match "[-_][^-_]+$" term))
                    (substring term 0 hyphend)
!                 nil)))
!       (when term
!       ;; The terminal file has been loaded, now call the terminal
!       ;; specific initialization function.
!       (funcall (intern (concat "terminal-init-" term))))))
  
    ;; Update the out-of-memory error message based on user's key bindings
    ;; for save-some-buffers.

(I didn't include the changes to the term/*.el files, the difference
to the previous version of this patch is just deleting the
;;;###autoload lines and renaming the terminal initialization
functions).




reply via email to

[Prev in Thread] Current Thread [Next in Thread]