Re: emacsclient horribly broken

[Juanma Barranquero]

On 11/2/06, Tim Van Holder <address@hidden> wrote:

> 1) emacs -f server-start with server-use-tcp set to off throws an error
>    (cannot bind to socket: address already in use). If server-use-tcp is
>    enabled, the error disappears - so "old-style" local socket use is
>    currently broken.

Could you please investigate this? I cannot test Unix sockets.

> 2) emacsclient fails to find the TCP-based server by default;
[...]
> Because linux has file system sockets, the default server_file
> (server) is never tried.

That is by design. People asked for emacsclient to default to local
sockets (if available), and not to use TCP sockets unless explicitly
requested. If you want it to always use TCP, you can set the
environment variable EMACS_SERVER_FILE, so server_file will always be
defined.

> The other patch, no-nonblock.patch
> removes the fcntls/ioctls from emacsclient.c entirely.

The non-blocking code is from my old patch, more than a year ago, and
I think I added it while wrestling with a server bug on Windows.
You're right that it works without it and, in fact, simplifies things,
so I'm gonna commit your patch.

Thanks,
                   /L/e/k/t/u