[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem with tumme.el

From: Stefan Monnier
Subject: Re: problem with tumme.el
Date: Sat, 13 Jan 2007 20:02:52 -0500
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.92 (gnu/linux)

> shell-file-name is /bin/bash.

That's the bug.  `shell-file-name' should be /bin/sh.
As for your patch: it's an improvement because it relies less on the shell
It could actually avoid the shell altogether now, which would avoid
quoting problems.  E.g.:

  "%p -rotate %d -copy all -outfile %t \"%o\""

obviously, this assumes that quoting is done via the \"%o\" which
breaks if %o contains ".


PS: Also if %o assumes the quoting is done in tumme-cmd-rotate-original-options
rather than in %o itself, then I guess that if %d or %p contains metachars
like >, &, ;, SPC, etc... we may get very funny behavior.  It's probably
not a problem for those because they're under tight control (or it might
even be a desirable feature so that %p can expand to a command with some

reply via email to

[Prev in Thread] Current Thread [Next in Thread]