[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The highlight of "common prefix" in completion buffer is broken.

From: Stefan Monnier
Subject: Re: The highlight of "common prefix" in completion buffer is broken.
Date: Wed, 07 Feb 2007 10:37:53 -0500
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux)

> Reverting the following change fixes the bug:

> 2007-01-30  Richard Stallman  <address@hidden>

>       * minibuf.c (read_minibuf):
>       Save and clear Vminibuffer_completing_file_name.
>       (read_minibuf_unwind): Restore it.
>       (Vminibuffer_completion_table, Qminibuffer_completion_table)
>       (Vminibuffer_completion_predicate, Qminibuffer_completion_predicate)
>       (Vminibuffer_completion_confirm, Qminibuffer_completion_confirm)
>       (Vminibuffer_completing_file_name): Definitions moved up.

> Yes I know that this change was made to fix some other bug,
> but the number of things broken by that change is increasing,
> so that change doesn't seem like the right fix!!

Indeed, but it's not clear what's The Right Fix.  Maybe instead of let-binding
Vminibuffer_completing_file_name, we should set it buffer-locally.
Yes, I think it would be a better fix, but it's still not clear how to do
it, because we'd like to set it in Fread_file_name, but the buffer is only
created in read_minibuf.

Basically, one would want to use minibuffer-setup-hook, but this presents
similar difficulties: rather than a global var (i.e. an implicit arg), what
we really want is to pass it as an explicit `setup' argument.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]