face-set-after-frame-default overrides face customization

[Juri Linkov]

The 2007-03-11 change in faces.el::face-set-after-frame-default broke
.emacs face customizations in such a way that it overrides the face
modifications made in .emacs by Lisp functions like `set-face-attribute'
after face customization is completed by `custom-set-faces'.

The cause of this change in the default Emacs behavior is the
following code:

            ;; If the user has customized the face, don't let X
            ;; resources override the customizations.
            (if (get face 'theme-face)
                (custom-theme-recalc-face face)))

I think this change should be reverted, and to achieve what it tries
to do is possible by adding the same condition `(get face 'theme-face)'
with `unless' just around the call to `make-face-x-resource-internal'
a few lines above in the same function like:

            (unless (get face 'theme-face)
                (make-face-x-resource-internal face frame))
            ...

Could someone confirm that this will fix the problem with X resources
the latest change was attempted to fix?

-- 
Juri Linkov
http://www.jurta.org/emacs/