emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Display problems with 'before-string in overlay


From: Chong Yidong
Subject: Re: Display problems with 'before-string in overlay
Date: Wed, 11 Apr 2007 16:54:34 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.97 (gnu/linux)

"Lennart Borgman (gmail)" <address@hidden> writes:

>>>   if (PT == MATRIX_ROW_END_CHARPOS (row))
>>>     {
>>>       /* If the row ends with a newline from a string, we don't want
>>>          the cursor there, but we still want it at the start of the
>>>          string if the string starts in this row.
>>>          If the row is continued it doesn't end in a newline.  */
>>>       if (CHARPOS (row->end.string_pos) >= 0)
>>>         cursor_row_p = (row->continued_p
>>>                         || PT >= MATRIX_ROW_START_CHARPOS (row));
>>>
>>> Changing this last line to `cursor_row_p = row->continued_p;', as it
>>> was before, eliminates the bug.  I haven't thought about how to fix
>>> this, though.
>>
>> FWIW, I wouldn't touch this so close to the release: if no one noticed
>> this since July 2005, it's hardly a grave bug.
>
>
> How do you know? This just looks so strange so it could well be a
> grave bug.

Its only effect is that if a before-string spans multiple lines then
the cursor ends up being displayed on the end of the first line.  It
does not have any further implications, such as crashing Emacs or
corrupting data.

As for whether or not to change the code, I guess it's up to KFS.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]