regression in diary-lib

[Andreas Seltenreich]

> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.

> Your bug report will be posted to the address@hidden mailing list.

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:

I just switched from 22.0.96 to 22.0.98 and noticed that the file-local
variables in my ~/diary file are no longer honored.  It seems like the
following change causes buffer-local variables to be flushed on each
call to diary-view-entries:

> Changes by:   Glenn Morris <gm>       07/03/21 06:25:00

> Index: diary-lib.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/calendar/diary-lib.el,v
> retrieving revision 1.120
> retrieving revision 1.121
> diff -u -b -r1.120 -r1.121
> --- diary-lib.el      20 Mar 2007 07:45:06 -0000      1.120
> +++ diary-lib.el      21 Mar 2007 06:24:59 -0000      1.121
[...]
> @@ -429,7 +435,10 @@
>              (or (verify-visited-file-modtime diary-buffer)
>                  (revert-buffer t t))))
>          ;; Setup things like the header-line-format and invisibility-spec.
> -        (when (eq major-mode default-major-mode) (diary-mode))
> +        ;; This used to only run if the major-mode was default-major-mode,
> +        ;; but that meant eg changes to header-line-format did not
> +        ;; take effect from one diary invocation to the next.
> +        (diary-mode)
>          ;; d-s-p is passed to the diary display function.
>          (let ((diary-saved-point (point)))
>            (save-excursion