[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch for locate.el when called with prefix arg
From: |
Chong Yidong |
Subject: |
Re: patch for locate.el when called with prefix arg |
Date: |
Fri, 20 Apr 2007 14:11:15 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.98 (gnu/linux) |
Luc Teirlinck <address@hidden> writes:
> Francesco Potorti` <address@hidden> wrote:
>
> A bug was apparently introduced in locate.el, but I did not check when
> and why.
>
> That was not the only bug introduced by the following change:
>
> 2006-09-09 Matt Hodges <address@hidden>
>
> * locate.el (locate-current-search): New variable.
> (locate): Set buffer local value. Use current buffer if it is
> in Locate mode.
> (locate-mode): Disable undo here.
> (locate-do-setup): Use locate-current-filter from buffer to be killed.
> (locate-update): Use locate-current-search and locate-current-filter.
>
> Undo no longer works in a locate buffer. This is a serious bug and a
> regression in Emacs 22 if it does not get fixed. You are supposed to
> be able to do essentially everything you can do in a dired buffer
> (including undo) in a locate buffer. That is the very purpose of
> locate-mode.
>
> From the above changelog entry, this bug seems to have been introduced
> _on purpose_. What was the purpose of the above changes? They seem to
> have been made by somebody who does not understand how other people
> use locate mode and only cares about the way he personally uses it.
> Who knows what else these changes broke.
FWIW, the only discussion of this I could find is here:
http://lists.gnu.org/archive/html/emacs-pretest-bug/2006-09/msg00068.html
From: Matt Hodges
Subject: Reverting locate buffers.
Date: Tue, 05 Sep 2006 14:08:37 +0100
Reverting Locate mode buffers (via locate-update) currently ignores
filters from locate-with-filter. It also doesn't work with uniquely
renamed buffers, or when locate has been called non-interactively
(e.g., from eshell/locate) and locate-history-list and
locate-grep-history-list aren't modified.
The attached patch has suggested changes to address these issues. If
suitable, a ChangeLog entry is:
2006-09-05 Matt Hodges <address@hidden>
* locate.el (locate-current-search): New variable.
(locate): Set buffer local value. Use current buffer if it is
in Locate mode.
(locate-mode): Disable undo here.
(locate-do-setup): Use locate-current-filter from buffer to be
killed.
(locate-update): Use locate-current-search and
locate-current-filter.
Thanks,
Matt
- Re: patch for locate.el when called with prefix arg, (continued)
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/24
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/24
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/21
Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/20
Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/20
Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/20
Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/20