[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch for locate.el when called with prefix arg
From: |
Luc Teirlinck |
Subject: |
Re: patch for locate.el when called with prefix arg |
Date: |
Sun, 22 Apr 2007 13:07:22 -0500 (CDT) |
With "something" scheduled for tomorrow, I can not wait for Richard's
response, since Richard asked to do this ASAP, which I interpret as
meaning before the next pretest, that is now. A choice between three
alternatives has to be made (see below), so I will wait some time for
input.
Richard Stallman wrote:
Is the way the `locate' command uses `current-prefix-arg', outside an
interactive declaration and without checking that `locate' itself was
called interactively, actually legitimate?
That is indeed a bug. All use of `current-prefix-arg' should be
in the interactive spec. Would some please fix it ASAP?
I plan to fix it by giving the locate command an extra arg and storing
the value of `current-prefix-arg' in it in the interactive declaration
for use in the body of the function. Other commands can then use that
arg to pass their own interactive arg on to the locate command if they
wish to do so.
Now we have to make a decision for `locate-with-filter' and
`locate-in-alternate-database'. These two commands currently pass
their interactive arg on to locate, which is undocumented and probably
unintentional, but could nevertheless be considered a "feature".
Now there are three things we could do. We could do something now and
something else after the release, if appropriate.
The three choices are: no longer pass the arg on, pass the arg on and
leave it undocumented, sticking with the current state of affairs (no
visible difference to the user), pass on and properly document.
Problem with the last two: I do not know how well tested the
unintentional "feature" is.
I plan to also commit my previously mentioned bug fixes, since they
are way less invasive than the new change, fix annoying and confusing
bugs and I tested them extensively. They are an obvious complement to
already committed changes.
Sincerely,
Luc Teirlinck.
- patch for locate.el when called with prefix arg, Francesco Potorti`, 2007/04/20
- Re: patch for locate.el when called with prefix arg, Chong Yidong, 2007/04/20
- Re: patch for locate.el when called with prefix arg, Matt Hodges, 2007/04/21
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/21
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/21
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/21
- Re: patch for locate.el when called with prefix arg, Richard Stallman, 2007/04/22
- Re: patch for locate.el when called with prefix arg,
Luc Teirlinck <=
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/22
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Miles Bader, 2007/04/23
- Re: patch for locate.el when called with prefix arg, Luc Teirlinck, 2007/04/23