[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hl-line-face should be a face, not an option

From: Stephen Berman
Subject: Re: hl-line-face should be a face, not an option
Date: Mon, 07 May 2007 13:07:16 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux)

On Sat, 26 Aug 2006 18:15:08 -0700 "Drew Adams" <address@hidden> wrote:

> It would be better to define a face `hl-line' than to have option
> `hl-line-face', whose value must be an existing face. It's easier for
> users to tweak a face definition than it is for them to find an
> appropriate face ready-made, especially for something like this, which
> is fairly intrusive. To get something else, they are obliged to define
> a face themselves, which requires knowledge of Lisp.

It appears this request was implemented by this change:

   2006-08-29  Chong Yidong  <address@hidden>
        * hl-line.el (hl-line): New face.
        (hl-line-face): Use it.

But instead of replacing hl-line-face, hl-line was made the default
value of hl-line-face.  But both can be set independently, and when
they differ, hl-line-face is what is actually used by hl-line-mode.
What advantage does this possibility have?  It seems at least
potentially confusing.  Why not simply have hl-line-face defalias'd to
hl-line?  Wouldn't that suffice for backward compatibility (assuming
that was the reason for retaining hl-line-face)?

Steve Berman

reply via email to

[Prev in Thread] Current Thread [Next in Thread]