[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars
From: |
Chong Yidong |
Subject: |
Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars |
Date: |
Sun, 03 Jun 2007 13:07:52 -0400 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) |
Richard Stallman <address@hidden> writes:
> > If my change broke something, then please undo it; but in that case,
> > please put in whatever GCPROs are needed for x_encode_text.
>
> The GCPRO you added in x_encode_text was not deleted.
>
> I know that, but we are miscommunicating. There needs to be a GCPRO
> in x_set_name_internal around the calls to x_encode_text, at least to
> protect the variable encoded_name. Or else the code needs to be
> rearranged so encoded_name is not used after the calls to
> x_encode_text.
Ah, now I understand what you are saying. But even if your change had
been left in place, wouldn't these GCPRO would have been needed anyway
(for the case where HAVE_GTK is false)?
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, (continued)
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, YAMAMOTO Mitsuharu, 2007/06/01
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Chong Yidong, 2007/06/01
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Chong Yidong, 2007/06/01
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, YAMAMOTO Mitsuharu, 2007/06/01
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Chong Yidong, 2007/06/02
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Jan Djärv, 2007/06/02
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Richard Stallman, 2007/06/02
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Chong Yidong, 2007/06/02
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Richard Stallman, 2007/06/03
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars,
Chong Yidong <=
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Richard Stallman, 2007/06/03
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, YAMAMOTO Mitsuharu, 2007/06/03
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Kenichi Handa, 2007/06/03
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, YAMAMOTO Mitsuharu, 2007/06/03
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Richard Stallman, 2007/06/04
- Re: Crash: XSetWMIconName, x_set_name_internal, prepare_menu_bars, Richard Stallman, 2007/06/04