[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] [PATCH] Enhancements to the code smell detector.
From: |
James Youngman |
Subject: |
Re: [Findutils-patches] [PATCH] Enhancements to the code smell detector. |
Date: |
Sat, 30 Jun 2007 13:32:52 +0100 |
On 6/30/07, James Youngman <address@hidden> wrote:
2007-06-30 James Youngman <address@hidden>
Enhancements to the code smell detector.
* Makefile.am (findutils-check-smells): Automate the calling of
build-aux/src-sniff.py.
* build-aux/src-sniff.py: Rework to use a list of regex-based
sniffers, to allow checking types of file other than C. Allow
file-based regex sniffers to give an indication of the line number
where they think the problem (or part of the problem) exists.
Added code smell detectors for a sample Bourne shell problem and
for out-of-date FSF addresses.
I applied these changes without waiting for a review, on the basis
that it doesn't touch any of the installed code, and this program is
not invoked during the build process either.
James.