Re: FYI: four small changes

[Paul Eggert]

On 2023-04-09 22:42, Jim Meyering wrote:

> +      unsigned char buf[128];
> +      (void) pcre2_config (PCRE2_CONFIG_VERSION, buf);
> +      fputs (_("\nBuilt with PCRE "), stdout);
> +      puts ((char *) buf);

Doesn't this output the version of PCRE that grep is linked to 
(typically dynamically), as opposed to the version grep was built with? 
Unless "built" is meant to also include the dynamic linking phase during 
execution, which isn't how I interpreted "built".

How about the attached followup patch? It also moves this stuff into 
pcresearch.c, says PCRE2 is used by grep -P in case people worry about 
ordinary grep using PCRE, says "PCRE2" instead of "PCRE", and checks for 
pcre2_config buffer overflow (I know, too late, but this is the best we 
can do).

0001-grep-improve-PCRE2-version-output.patch
Description: Text Data