[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: guile: Add guile-irregex.
From: |
Christopher Allan Webber |
Subject: |
Re: [PATCH] gnu: guile: Add guile-irregex. |
Date: |
Fri, 06 Nov 2015 10:58:58 -0600 |
Ludovic Courtès writes:
> Christopher Allan Webber <address@hidden> skribis:
>
>> On a side note, it would really be nice to have a
>> r6rs-build-system... starting to result in a lot of similar spaghetti in
>> a few of these packages.
>
> Is there really a standard R6 way of doing things?
>
> I agree some factorization would be welcome anyhow!
I don't really know, that comes from reading the Guildhall README:
https://github.com/ijp/guildhall/blob/master/README
> === Background ==========================================================
> Guildhall is a port of Andreas Rottmanns Dorodango portable package manager
for
> R6RS Scheme, adapted to better fit in with Guile Scheme environments.
> It is compatible with the R6RS Scheme package archives that Dorodango uses.
>
> dorodango is (intended to be) a package manager for R6RS
> implementations. Its main concepts are outlined in this thread:
>
<http://groups.google.com/group/ikarus-users/browse_thread/thread/fabb890e3015f6f1>.
So I've thought there's something probably, but I haven't really looked
enough...
>> + `(#:modules ((guix build utils)
>> + (ice-9 match)
>> + ,@%gnu-build-system-modules)
>
> I think (guix build gnu-build-system) is enough on the 3rd line.
Good call.
>> + (synopsis "S-expression based regular expressions, packaged for Guile")
>
> I’d remove “, packaged for Guile”.
>
> Otherwise LGTM, thank you!
>
> Ludo’.
Done, and pushed!