[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] edit: Friendlier error message.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] edit: Friendlier error message. |
Date: |
Wed, 11 Nov 2015 23:01:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Mathieu Lirzin <address@hidden> skribis:
> address@hidden (Ludovic Courtès) writes:
>
>> Andreas Enge <address@hidden> skribis:
>>
>>> On Thu, Nov 05, 2015 at 12:08:35PM +0100, Ludovic Courtès wrote:
>>>> > + (unless (search-path (parse-path (getenv "PATH")) (%editor))
>>>> > + (leave (_ "Couldn't find editor '~a'. Please check $EDITOR and
>>>> > $PATH.")
>>>> > + (%editor)))
>>>
>>> An additional, heterodox suggestion: Maybe also test for $VISUAL.
>>
>> AIUI, $VISUAL is for visualizing files, not for editing, no?
>
> I can't remember where I have read this, but I think this 2 variables
> exist to distinguish between line editing à la Ed, and visual editing
> à la VI.
SUS mentions ‘VISUAL’ but without saying what it’s for:
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08
But
<http://unix.stackexchange.com/questions/4859/visual-vs-editor-whats-the-difference>
says something that seems to make sense, like what you wrote.
I’ve committed a change that honors $VISUAL first, $EDITOR second.
Thanks,
Ludo’.