[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Add love and devil
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCHES] Add love and devil |
Date: |
Mon, 16 Nov 2015 21:55:25 +0100 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
David Thompson <address@hidden> writes:
> Yes, these are real software packages! LÖVE is a neat game framework
> that uses Lua and depends on DevIL for image loading.
Yay for LÖVE!
> +(define-public devil
> + (package
> + (name "devil")
[...]
> + (arguments
> + '(#:configure-flags '("--enable-ILUT=yes") ; build utility library
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'fix-tests
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; Fix hard-coded /bin/bash reference.
> + (substitute* '("test/Makefile")
> + (("TESTS_ENVIRONMENT = /bin/bash")
> + (string-append "TESTS_ENVIRONMENT = "
> + (assoc-ref inputs "bash")
> + "/bin/bash")))
> + #t)))))
Could this be fixed by passing “TESTS_ENVIRONMENT” as a make-flag
instead?
Otherwise looks good to me (both this and the second patch).
Thank you!
~~ Ricardo