[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add python-contextlib2
From: |
Andreas Enge |
Subject: |
Re: [PATCH] gnu: Add python-contextlib2 |
Date: |
Wed, 18 Nov 2015 09:46:40 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
Hello,
and congratulations for your first package!
Upon a quick glance, I have the following comments:
> gnu: Add python-contextlib2
Please add a "." at the end of the line.
> * gnu/packages/python.scm (python-contextlib2, python2-contextlib2):
> New variables.
> gnu/packages/patches/python-contextlib2.patch | 51
> +++++++++++++++++++++++++++
> gnu/packages/python.scm | 24 +++++++++++++
> 2 files changed, 75 insertions(+)
You also need to add the patch to gnu-system.am. Then add two lines to the
commit log explaining the changes to the two other files; you will find
examples in the commit history.
At the top of a patch file, we usually provide a little explanation of why
the patch is needed; if it concerns a problem to be fixed upstream, we
usually report the bug and add a reference to the bug url; if it comes
from another distribution we give the reference.
Did you run "./pre-inst-env guix lint python-contextlib2" etc.? This can
detect potential problems. (I did not try it on your patch, and am just
asking because I tend to forget it myself.)
I let the python gurus comment on the content of the package.
Andreas