[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add cereal + sparsehash
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add cereal + sparsehash |
Date: |
Sat, 28 Nov 2015 16:42:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> The first patch adds a new “serialization” module for libraries such as
> cereal.
Maybe protobuf should be moved there? I don’t know if there are other
candidates.
> The second patch adds “sparsehash” to the “crypto” module. It’s
> probably not the best module for this package — can you suggest any
> other location for a hash table library?
No idea, this one should be fine.
> From 19a28042f3839ea23aa13f4973172ca46cfde5f0 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Mon, 9 Nov 2015 14:46:56 +0100
> Subject: [PATCH 1/2] gnu: Add cereal.
>
> * gnu/packages/serialization.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (doc (string-append out "/share/cereal/docs"))
> + (include (string-append out "/include/cereal")))
> + (mkdir-p doc)
> + (mkdir-p include)
> + (copy-recursively "include/cereal" include)
> + (copy-recursively "doc/html" doc))
Maybe add a comment about why “make install” isn’t enough.
Otherwise LGTM.
> From 1f8739407dd3f9715005d55befabf894fa98ee10 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 10 Nov 2015 15:41:04 +0100
> Subject: [PATCH 2/2] gnu: Add sparsehash.
>
> * gnu/packages/crypto.scm (sparsehash): New variable.
LGTM.
Thanks!
Ludo’.