[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add nethogs
From: |
Leo Famulari |
Subject: |
Re: Add nethogs |
Date: |
Thu, 10 Mar 2016 16:41:36 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Mar 10, 2016 at 01:52:56PM +0000, Raimon Grau wrote:
>
> Raimon Grau writes:
>
> > I ran lint on it (forgot to do it previously), and now it complies with
> > everything but "the source file name should contain the package name",
> > although afaict it does contain it. I'll try to investigate more on that
> > but that's the 'more correct version'.
>
> Apparently it's a warning that has to be there because indeed, the file
> name doesn't contain the package name but only a version.
GitHub's generated tarballs are almost always named something like
v0.8.1.tar.gz. They don't include the name of the project itself (or the
package).
If you grep for 'file-name' in gnu/packages, you'll find some examples
of how to name the output file.
Also, the patch does not apply to current HEAD of master (ff22f01d67). I
see in your patch the following context that I can't find in the master
branch. Did you generate the patch on top of another local patch?
> @@ -209,3 +210,38 @@ bandwidth usage in real time. It visualizes the in- and
> outgoing traffic using
> two graphs and provides additional info like total amount of transfered data
> and min/max network usage.")
> (license license:gpl2)))
> +
> +(define-public nethogs
> + (package
[...]
Can you send an updated patch?